Skip to content

fix: update assets URL and create directories recursively #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix: update assets URL and create directories recursively #245

merged 2 commits into from
Jun 11, 2024

Conversation

vitorhcl
Copy link
Member

@vitorhcl vitorhcl commented Jun 10, 2024 •
edited by kbdharun
Loading

  • Update DOWNLOAD_CACHE_LOCATION location to GitHub releases
  • Fixed a regression caused by pathlib refactoring, path.mkdir needs parents=True to create the directories recursively

@vitorhcl vitorhcl changed the title fix: update DOWNLOAD_CACHE_LOCATION and create directories recursively fix: update assets URL and create directories recursively Jun 10, 2024
kbdharun
kbdharun reviewed Jun 10, 2024
View reviewed changes
kbdharun
kbdharun approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit f029e67 into tldr-pages:main Jun 11, 2024
8 checks passed
@vitorhcl vitorhcl deleted the fix_cache_dir_creation branch June 11, 2024 12:40
@kbdharun kbdharun added this to the 3.3.0 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@spageektti spageektti spageektti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vitorhcl @kbdharun @spageektti